Workaround: Separate saved searches with tags name #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since unfortunately saved searches and tags share the same namespace, it makes it difficult to create a saved search with the exact name as an existing tag. As a current workaround until we separate them, we just prefix the saved searches with SEARCH_TAG_PREFIX, which an user is unlikely to use. From what I can see, it still displays properly in the UI after some fixes, aside from existing bugs. In the XML file this prefix isn't added, because it would be redudant and make it easier to deal with in future versions.
|
Always impressed by how thorough your are with these PRs, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since unfortunately saved searches and tags share the same namespace, it
makes it difficult to create a saved search with the exact name as an
existing tag.
As a current workaround until we separate them, we just prefix the saved
searches with
SEARCH_TAG_PREFIX, which an user is unlikely to use.From what I can see, it still displays properly in the UI after some
fixes, aside from existing bugs, like the tag editor stripping spaces,
@blog !or @efficiencyhaving the first@stripped out in the sidebar, and so on.In the XML file this prefix isn't added, because it would be redundant
and make it easier to deal with in future versions.
See for example #629. Does not fix tag inconsistencies (renaming, special symbols etc.).